Conversation
(This was probably a cut-n-paste from block validation)
The spec currently defines `MAX_REQUEST_BLOB_SIDECARS` as the "maximum number of blob sidecars in a single request", but then later in the RPC description defines the max is `MAX_REQUEST_BLOB_SIDECARS * MAX_BLOBS_PER_BLOCK`. Clean this up by defining `MAX_REQUEST_BLOB_SIDECARS` to be the actual max.
fix MAX_REQUEST_BLOBS_SIDECARS typo
Fix outdated (likely a Bellatrix cut-paste) description of change.
Minor typo/pasta fixes in blob_sidecar_{index} validation
Remove the outdated description in Deneb fork
Update fork-choice.md
Fork choice upgrade
Deneb : Change description for blob
Deneb crypto helpers test coverage
Shift all fork choice tests to Altair & later
Check correct fork version in LC sync protocol
Fix `get_sample_opaque_tx` call signature
Remove phase 0 from fork choice test generator
bump version.txt
Add EIP-6110 spec links to README table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo:
get_sample_opaque_txcall signature #3296